Avoid sending empty profiles - #2232
Merged
Merged
Conversation
added unit and ui test to check empty profiles are discarded profiling sample activity default flag switched
added unit and ui test to check empty profiles are discarded profiling sample activity default flag switched
Codecov ReportBase: 80.62% // Head: 80.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
============================================
+ Coverage 80.62% 80.64% +0.01%
- Complexity 3357 3358 +1
============================================
Files 240 240
Lines 12335 12337 +2
Branches 1638 1639 +1
============================================
+ Hits 9945 9949 +4
+ Misses 1783 1782 -1
+ Partials 607 606 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
stefanosiano
marked this pull request as ready for review
September 5, 2022 16:11
adinauer
approved these changes
Sep 6, 2022
vaind
pushed a commit
that referenced
this pull request
Sep 7, 2022
* added a check on the sampled profile not to be empty in order to be sent * added unit and ui test to check empty profiles are discarded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added a check on the sampled profile not to be empty in order to be sent
💡 Motivation and Context
We received few profiles without any content. There is already a check if the profiling trace file doesn't exists or cannot be read, but no check if it is empty. I couldn't be able to reproduce the issue, other than changing the content of the file right before being sent.
However, this should fix it
💚 How did you test it?
I added both a Unit and a Ui test to check empty profiles are discarded
📝 Checklist